[libcxx-commits] [PATCH] D130562: [libc++] Rename __libcpp_assertion_handler to __libcpp_verbose_abort

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Some additional information on this patch like I just explained in Discord:

I want to use a verbose abort handler in more places, like when we `std::abort` due to an exception in `-fno-exceptions` mode (today the experience sucks cause it only calls `std::abort()` with no message, so good luck finding where an exception was thrown). In the future, we can also most likely call it from `std::unreachable()`. It would also allow de-duplicating the same functionality we have in libc++abi.

I have to admit that given this generality, I'm not 100% sure anymore it is worth making it possible for users to override the function, although I guess it doesn't add too much complexity. I'd welcome input on this question and also the naming of the function, documentation changes, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130562/new/

https://reviews.llvm.org/D130562