[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

Tue Jul 26 06:23:08 PDT 2022

hans added a comment.

In D128146#3676615 <https://reviews.llvm.org/D128146#3676615>, @ldionne wrote:

> In D128146#3675833 <https://reviews.llvm.org/D128146#3675833>, @hans wrote:
>
>> which is very close to the 4 GB limit, so we have to address that anyway, I just wanted to flag this so the growth didn't go unnoticed.
>
> @philnik Made some experiments and the current theory is that the bulk of the increase in debug information is caused by the fact that we now destroy the elements when an exception is thrown. That was previously a bug and it is being fixed by this patch.

We build with `-fno-exceptions` though, though I'm not sure if that affects this?

> Given that the 4gb limit will have to be addressed regardless, we would like to land this patch (which will unblock `constexpr std::vector`) and tackle improvements to debug information after the LLVM 15 branch has been created. Depending on the nature of the fix, we may be able to cherry-pick back to LLVM 15.
>
> @hans @joanahalili  @alexfh  Does that sound reasonable? By the way, thanks for the heads up, this sort of input is super useful in finding things that we would not be able to easily see otherwise.

Sounds reasonable to me, though I can't speak for @joanahalili and @alexfh.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146