[libcxx-commits] [PATCH] D130562: [libc++] Rename __libcpp_assertion_handler to __libcpp_verbose_abort

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: arichardson, mgorny, nemanjai.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

With the goal of reusing that handler to do other things besides
handling assertions (such as terminating when an exception is thrown
under -fno-exceptions), the name `__libcpp_assertion_handler` doesn't
really make sense anymore.

Furthermore, I didn't want to use the name `__libcpp_abort_handler`,
since that would give the impression that the handler is called
whenever `std::abort()` is called, which is not the case at all.

Finally, as a drive-by fix, this patch makes the verbose abort handler
[[noreturn]], since that is effectively required in order to use it
beyond the handling of assertions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130562

Files:
  libcxx/docs/UsingLibcxx.rst
  libcxx/include/CMakeLists.txt
  libcxx/include/__assert
  libcxx/include/__availability
  libcxx/include/__verbose_abort
  libcxx/lib/abi/CHANGELOG.TXT
  libcxx/lib/abi/arm64-apple-darwin.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/powerpc-ibm-aix.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/powerpc64-ibm-aix.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.nonew.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.noexceptions.nonew.abilist
  libcxx/src/CMakeLists.txt
  libcxx/src/assert.cpp
  libcxx/src/verbose_abort.cpp
  libcxx/test/libcxx/assertions/customize_handler.backdeployment.pass.cpp
  libcxx/test/libcxx/assertions/customize_handler.pass.cpp
  libcxx/test/libcxx/assertions/debug_mode_compatibility.pass.cpp
  libcxx/test/libcxx/assertions/default_handler.availability.verify.cpp
  libcxx/test/libcxx/assertions/headers_declare_assertion_handler.sh.cpp
  libcxx/test/libcxx/assertions/headers_declare_handler.sh.cpp
  libcxx/test/libcxx/private_headers.verify.cpp
  libcxx/test/support/check_assertion.h
  libcxx/utils/generate_header_tests.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130562.447649.patch
Type: text/x-patch
Size: 54427 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220726/b76b22f8/attachment-0001.bin>