[libcxx-commits] [PATCH] D130541: [cmake] Dedup linker flag check polyfill

John Ericson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 25 20:34:43 PDT 2022


Ericson2314 created this revision.
Herald added subscribers: libcxx-commits, Enna1, mgorny.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
Ericson2314 requested review of this revision.
Herald added projects: Sanitizers, libc++, libc++abi, LLVM.
Herald added subscribers: llvm-commits, Sanitizers.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

Finishing what https://reviews.llvm.org/D117537 started. This is also
what @phosek wanted.

We had two issues before, which are now fixed.

1. `HandleOutOfTreeLLVM` didn't work with compiler-rt

  Removed in D125561 <https://reviews.llvm.org/D125561>

2. CMake's `CMP0056` couldn't be relied upon

  Locally forced on in D118546 <https://reviews.llvm.org/D118546>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130541

Files:
  cmake/Modules/LLVMCheckCompilerLinkerFlag.cmake
  compiler-rt/cmake/config-ix.cmake
  libcxx/cmake/config-ix.cmake
  libunwind/cmake/config-ix.cmake
  llvm/cmake/modules/LLVMCheckLinkerFlag.cmake
  runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130541.447543.patch
Type: text/x-patch
Size: 9333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220726/cc6f6cdf/attachment.bin>


More information about the libcxx-commits mailing list