[libcxx-commits] [PATCH] D129823: [libc++][ranges] Make range algorithms support proxy iterators

[Alexander Kornienko via Phabricator via libcxx-commits]

alexfh added a comment.

In D129823#3677825 <https://reviews.llvm.org/D129823#3677825>, @alexfh wrote:

> In D129823#3670225 <https://reviews.llvm.org/D129823#3670225>, @alexfh wrote:
>
>> In D129823#3667506 <https://reviews.llvm.org/D129823#3667506>, @var-const wrote:
>>
>>> In D129823#3667454 <https://reviews.llvm.org/D129823#3667454>, @eaeltsin wrote:
>>>
>>>> Thanks Konstantin, now it works!
>>>
>>> Excellent, thanks a lot for checking and reporting back! The credit for the second patch goes to @huixie90.
>>
>> And the final confirmation: our full test run didn't find any more issues related to this commit. Thanks again for the prompt fix!
>
> Sad news: there's another problem caused by this commit (and not fixed by https://reviews.llvm.org/D130212), which wasn't detected initially. The problem is some sort of a data corruption happening in a version of MySQL. I think, the version we see this in should be close to this one: https://fossies.org/dox/mysql-8.0.29/varlen__sort_8h_source.html. A standalone repro is being worked on, but maybe the original code gives enough information to work with.

This code seems to be calling to sort with some custom iterators, which leads to the corruption of the data being sorted: https://github.com/mysql/mysql-server/blob/8.0/sql/handler.cc#L6779


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129823/new/

https://reviews.llvm.org/D129823