[libcxx-commits] [PATCH] D130507: [libc++] Generalize the customizeable assertion handler

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 25 13:15:14 PDT 2022


ldionne added inline comments.


================
Comment at: libcxx/src/assert.cpp:28
 _LIBCPP_WEAK
-void __libcpp_assertion_handler(char const* __file, int __line, char const* __expression, char const* __message) {
-  std::fprintf(stderr, "%s:%d: libc++ assertion '%s' failed. %s\n", __file, __line, __expression, __message);
+void __libcpp_assertion_handler(char const* __format, ...) {
+  // Write message to stderr. We do this before formatting into a
----------------
philnik wrote:
> Why are you __uglyfying the names inside the `.cpp`?
I'm used to it, I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130507/new/

https://reviews.llvm.org/D130507



More information about the libcxx-commits mailing list