[libcxx-commits] [PATCH] D129716: [libc++][NFC] Use is_void instead of is_same<void, ...>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 22 09:08:05 PDT 2022


ldionne added inline comments.


================
Comment at: libcxx/test/std/containers/container.adaptors/queue/queue.defn/emplace.pass.cpp:36
 #else
-    static_assert(std::is_same<queue_return_type, void>::value, "");
+    static_assert(std::is_void<queue_return_type>::value, "");
 #endif
----------------
IMO `is_same` reads better here (and in the other two test files) since it is more symmetric with other tests for the return type, where we check `is_same<queue_return_type, SOMETHING>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129716/new/

https://reviews.llvm.org/D129716



More information about the libcxx-commits mailing list