[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

[Augusto Noronha via Phabricator via libcxx-commits]

augusto2112 added a comment.

@ldionne just by looking at the patch, I can't tell if it's clang or libcxx who is doing the wrong thing (I do see that the stack trace includes this new `__uninitialized_allocator_move_if_noexcept` function, which is hidden from the ABI, maybe that's part of the problem?) . It shouldn't be LLDB's responsibility to track down who is responsible after and it's not healthy for the project to xfail tests that are broken by one of its dependencies and investigate later on, which would just lead to more and more xfails. The LLVM policy <https://llvm.org/docs/DeveloperPolicy.html#id16> states that we should revert patches "If you break a buildbot in a way which can’t be quickly fixed, please revert.". So I think we should do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146