[libcxx-commits] [PATCH] D128146: [libc++] Use uninitialized algorithms for vector

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D128146#3669817 <https://reviews.llvm.org/D128146#3669817>, @avogelsgesang wrote:

> From the expanded "All failed tests" section on https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45513/testReport/
>
>   Assertion failed: (isa<InjectedClassNameType>(Decl->TypeForDecl)), function getInjectedClassNameType, file /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/lib/AST/ASTContext.cpp, line 4588.
>   PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
>   Stack dump:
>   0.	HandleCommand(command = "expr s_vector.push({4})")
>   1.	<eof> parser at end of file
>   2.	/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/include/c++/v1/stack:236:10: instantiating function definition 'std::stack<C, std::vector<C>>::push'
>   3.	/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/include/c++/v1/vector:577:36: instantiating function definition 'std::vector<C>::push_back'
>   4.	/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/include/c++/v1/vector:718:17: instantiating function definition 'std::vector<C>::__push_back_slow_path<C>'
>   5.	/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/include/c++/v1/vector:700:10: instantiating function definition 'std::vector<C>::__swap_out_circular_buffer'
>   6.	/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/include/c++/v1/__memory/uninitialized_algorithms.h:614:1: instantiating function definition 'std::__uninitialized_allocator_move_if_noexcept<std::allocator<C>, std::reverse_iterator<C *>, std::reverse_iterator<C *>, C, void>'

It doesn't look like libc++ is at fault here. If the goal is to get the test green again ASAP, I would XFAIL the test with a TODO and try to get someone from Clang to take a look, since it seems to be crashing inside Clang.

Reverting the libc++ patch will only hide the issue (like a XFAIL), but it will also be pretty disruptive for us.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128146/new/

https://reviews.llvm.org/D128146