[libcxx-commits] [PATCH] D130283: [libc++] Allow assigning std::rethrow_if_nested() to a function pointer

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I'm not too familiar with this code so I won't approve it. I wonder whether we want to allow taking the address of this function.



================
Comment at: libcxx/test/std/language.support/support.exception/except.nested/call_thru_funcptr.pass.cpp:7
+//
+//===----------------------------------------------------------------------===//
+
----------------
please don't use `thru` in the filename, use the complete word.


================
Comment at: libcxx/test/std/language.support/support.exception/except.nested/call_thru_funcptr.pass.cpp:35
+
+int main(void) {
+  {
----------------
Some of our supported platforms require this.


================
Comment at: libcxx/test/std/language.support/support.exception/except.nested/call_thru_funcptr.pass.cpp:39
+      B b(6);
+      void (*p)(B&) = &std::throw_with_nested;
+      p(b);
----------------
Is there wording in the Standard allowing this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130283/new/

https://reviews.llvm.org/D130283