[libcxx-commits] [PATCH] D128948: [libc++] Granularize some more type_traits

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 21 09:30:34 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with passing CI.



================
Comment at: libcxx/include/__type_traits/is_valid_expansion.h:21
+
+template <template <class...> class _Templ, class ..._Args, class = _Templ<_Args...> >
+true_type __sfinae_test_impl(int);
----------------
Not for this patch, but we should probably get rid of this. It seems maybe a bit over-engineered since we only use it in 1-2 places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128948/new/

https://reviews.llvm.org/D128948



More information about the libcxx-commits mailing list