[libcxx-commits] [PATCH] D129794: [libc++] Fix reverse_iterator::iterator_concept

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 21 09:24:42 PDT 2022


ldionne accepted this revision as: ldionne.
ldionne added a comment.

LGTM in essence, leaving final approval to others who chimed in on this. We should go through our archetypes and make sure they are as minimal as possible, i.e. we should probably have a `cpp20_xxxxx` and a `cpp17_xxxxx` version for each iterator that has differences between the two standards. Not for this patch, of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129794/new/

https://reviews.llvm.org/D129794



More information about the libcxx-commits mailing list