[libcxx-commits] [PATCH] D129823: [libc++][ranges] Make range algorithms support proxy iterators

Wed Jul 20 13:05:11 PDT 2022

ldionne added a comment.

In D129823#3666593 <https://reviews.llvm.org/D129823#3666593>, @alexfh wrote:

> In D129823#3666479 <https://reviews.llvm.org/D129823#3666479>, @ldionne wrote:
>
>> ... That information would be extremely useful in figuring out whether the issue is in libc++ or not.
>
> Well, I'm pretty sure it's related to the libc++ change in case of v8 inside nodejs.

The larger point I was making is that sometimes, we make changes in libc++ and that exposes problems in user code. If that were the case and Chromium's code was incorrect, there's nothing we could do on our end. I don't think this applies here, however -- I think we found the issue in libc++.

> The stack trace I posted earlier contains __introsort and __insertion_sort_3, which were affected by this patch. @eaeltsin is working on reproducing this with d8 <https://v8.dev/docs/d8>, which should be more compact than using nodejs.

@eaeltsin Can you try applying D130197 <https://reviews.llvm.org/D130197> to see if that fixes the issue? We'll commit it nonetheless because it fixes issues with proxy iterators, but it would be good to confirm that it indeed fixes your issue so we can stop looking.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129823/new/

https://reviews.llvm.org/D129823