[libcxx-commits] [PATCH] D130116: [libc++][ranges] implement `std::ranges::includes`

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 19 20:35:55 PDT 2022


jloser added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.set.operations/includes/ranges_includes.pass.cpp:239
+  withAllPermutationsOfIter1AndIter2();
   // TODO: A custom comparator works.
   // TODO: A custom projection works.
----------------
Nit: we can remove these TODOs since you have tests below with a custom comparator and custom projection, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130116/new/

https://reviews.llvm.org/D130116



More information about the libcxx-commits mailing list