[libcxx-commits] [PATCH] D130057: [libc++][ranges][NFC] Test that range algorithms support iterators requiring `iter_move`.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 19 13:43:48 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I'm happy with this approach (using a template and `if constexpr` to opt-out a few checks). However, if we end up having to add a lot more `if constexpr`, I would strongly consider copy-pasting the function instead to avoid adding too much logic in the tests. For the sake of keeping tests easy to validate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130057/new/

https://reviews.llvm.org/D130057



More information about the libcxx-commits mailing list