[libcxx-commits] [PATCH] D129741: [libc++][ranges][NFC] Consolidate range algorithm checks for returning `dangling`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM w/ comments. I think @philnik's comments have been addressed.



================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_nonbool_predicates.compile.pass.cpp:27
 
 auto unary_pred = [](int i) { return BooleanTestable(i > 0); };
 static_assert(!std::same_as<decltype(unary_pred(1)), bool>);
----------------
I think this should be a `.pass.cpp`.


================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.compile.pass.cpp:28
   constexpr bool binary_pred(const Foo& rhs) const { return val < rhs.val; }
   constexpr auto operator<=>(const Foo&) const = default;
 };
----------------
I think this should be a `.pass.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129741/new/

https://reviews.llvm.org/D129741