[libcxx-commits] [PATCH] D130070: [libc++][ranges] Implement `std::ranges::partition_{point, copy}`.

[Hui via Phabricator via libcxx-commits]

huixie90 added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.partitions/ranges_partition_copy.pass.cpp:270
+  }
 
   return true;
----------------
perhaps also tests "Complexity: Exactly last - first applications of pred and proj."


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.partitions/ranges_partition_point.pass.cpp:166
+      assert(result_no_proj == expected_no_proj);
+      auto result_with_proj = std::ranges::partition_point(in, is_odd, x2);
+      assert(result_with_proj == expected_with_proj);
----------------
can we have at least one test where the comparator is not `is_odd`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130070/new/

https://reviews.llvm.org/D130070