[libcxx-commits] [PATCH] D129976: [libc++] Add clang-tidy for the tests

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 19 12:59:45 PDT 2022


Mordante added a comment.

In D129976#3660847 <https://reviews.llvm.org/D129976#3660847>, @philnik wrote:

> In D129976#3660165 <https://reviews.llvm.org/D129976#3660165>, @Mordante wrote:
>
>> This means no changes to the test were required?
>>
>> LGTM! But please wait a few day before landing to give other reviews time to look at it.
>
> This is just to avoid sprinkling the tests with useless warnings everywhere. The clang-tidy on the tests isn't actually enforced.

In that case feel free to land it. We can reevaluate the setting when in the patch that enforces it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129976/new/

https://reviews.llvm.org/D129976



More information about the libcxx-commits mailing list