[libcxx-commits] [PATCH] D129922: [libcxx] Replace remaining _LIBCPP_INLINE_VISIBILITY in __support

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 19 12:57:34 PDT 2022


Mordante added a comment.

In D129922#3660150 <https://reviews.llvm.org/D129922#3660150>, @gulfem wrote:

> In D129922#3660085 <https://reviews.llvm.org/D129922#3660085>, @Mordante wrote:
>
>> Note that per LLVM policy you're free to revert breaking commits. This is not to put a burden on you, but not every developer is in the same timezone so it might take some time for the original author to see the issue their patch caused.
>
> Thank you very much @Mordante. I was under the impression that a quick fix is on the way, so that's why I did not immediately revert it.

No problem. I didn't know whether you knew this part of the policy. At first I felt the policy was odd, but I've really started to appreciate it, especially due to the timezone differences. (However I prefer not to introduce bugs ;-) )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129922/new/

https://reviews.llvm.org/D129922



More information about the libcxx-commits mailing list