[libcxx-commits] [PATCH] D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX

Xing Xue via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 19 08:09:50 PDT 2022


xingxue added inline comments.


================
Comment at: libcxx/include/__config:333
+#      define _LIBCPP_BASIC_IOS_HAS_FILL_SET 1
+#    elif defined(_WIN32) || defined(__APPLE__) || defined(__sun__)) || defined(__linux__) || defined(__FreeBSD__) ||  \
+          defined(__NetBSD__) || defined(__OpenBSD__)
----------------
Delete the extra `)`.


================
Comment at: libcxx/include/ios:800-801
+    }
+  }
+  else if (traits_type::eq_int_type(traits_type::eof(), __fill_)) {
+    __fill_ = widen(' ');
----------------



================
Comment at: libcxx/include/ios:813
+  char_type __r = fill();
+  __fill_ = __ch;
+  return __r;
----------------
Formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124555/new/

https://reviews.llvm.org/D124555



More information about the libcxx-commits mailing list