[libcxx-commits] [PATCH] D130031: [libc++][doc] Updates the release notes.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/docs/ReleaseNotes.rst:43
+LWG issues have been addressed. Since it is expected that at least one of these
+issues will cause an ABI break the library is considered experimental.
+
----------------
Complete nit, but maybe use `format library`? The first thought for me was "the whole library?".


================
Comment at: libcxx/docs/ReleaseNotes.rst:46
+The C++20 ``ranges`` library has progressed a lot since the last release and is
+almost complete. The library is considered [experimental|ready for general usage].
+
----------------
Mordante wrote:
> What will the status of ranges become?
I think the plan is to make ranges stable.


================
Comment at: libcxx/docs/ReleaseNotes.rst:52-75
+- P0627R6 Function to mark unreachable code
+- P1165R1 Make stateful allocator propagation more consistent for ``operator+(basic_string)``
+- P0674R1 Support arrays in ``make_shared`` and ``allocate_shared``
+- P0980R1 Making ``std::string`` constexpr
+- P2216R3 std::format improvements
+- P0174R2 Deprecating Vestigial Library Parts in C++17
+- N4190 Removing ``auto_ptr``, ``random_shuffle()``, And Old ``<functional>`` Stuff
----------------
I'd like to have some visual indicator that the text is the title of the paper. How about `P1234R5 - This is a really fascinating paper`?


================
Comment at: libcxx/docs/ReleaseNotes.rst:97-98
+
+- The functions ``std::from_chars`` and ``std::to_chars`` got 128-bit integral
+  support.
 
----------------



================
Comment at: libcxx/docs/ReleaseNotes.rst:133
   errors related to missing declarations in namespace ``std``, make sure you have the
   necessary includes.
 
----------------
Mordante wrote:
> Are these changes reverted too?
Yes, the transitive includes of public headers are (almost?) a superset of the ones included in LLVM 14.


================
Comment at: libcxx/docs/ReleaseNotes.rst:237
+- The legacy testing configuration is now deprecated and will be removed in LLVM 16. For
   most users, this should not have any impact. However, if you are testing libc++, libc++abi or
   libunwind in a configuration or on a platform that used to be supported by the legacy testing
----------------
Use the Oxford comma consistently or don't use it at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130031/new/

https://reviews.llvm.org/D130031