[libcxx-commits] [PATCH] D127033: [libc++] Define ostream nullptr inserter for >= C++17 only

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Still pending @ldionne's approval, but based on the feedback I think we should do this. But please add the requested comments. (That will avoid us trying to backport this again in the future.)



================
Comment at: libcxx/include/ostream:225
 
+#if _LIBCPP_STD_VER > 14
     _LIBCPP_INLINE_VISIBILITY
----------------
Please add comment this is LWG 2221 and add a rationale why this isn't backported, a link to this review suffices.


================
Comment at: libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters/streambuf.pass.cpp:70
     }
+#if TEST_STD_VER > 14
     { // LWG 2221 - nullptr
----------------
Please add comment that this LWG-issue isn't backported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127033/new/

https://reviews.llvm.org/D127033