[libcxx-commits] [PATCH] D129922: [libcxx] Replace remaining _LIBCPP_INLINE_VISIBILITY in __support

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D129922#3659570 <https://reviews.llvm.org/D129922#3659570>, @gulfem wrote:

> In D129922#3658571 <https://reviews.llvm.org/D129922#3658571>, @brad wrote:
>
>> In D129922#3658481 <https://reviews.llvm.org/D129922#3658481>, @phosek wrote:
>>
>>> Would it be possible to take a look?
>>
>> I'm sorry. I see the obvious mistake now.
>
> Could we please revert it until the issue is fixed because this breaks our builds?

It should be fixed by D129978 <https://reviews.llvm.org/D129978> which has landed shortly after your request.

Note that per LLVM policy you're free to revert breaking commits. This is not to put a burden on you, but not every developer is in the same timezone so it might take some time for the original author to see the issue their patch caused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129922/new/

https://reviews.llvm.org/D129922