[libcxx-commits] [PATCH] D129968: [libc++] Add a bunch of missing _LIBCPP_HIDE_FROM_ABI

Sun Jul 17 23:12:08 PDT 2022

var-const added a comment.

The `__algorithm` part LGTM. I'm ok with merge conflicts for my patches, they look simple to resolve.

================
Comment at: libcxx/test/libcxx/clang_query.sh.cpp:9
+
+// REQUIRES: has-clang-query
+
----------------
Mordante wrote:
> https://buildkite.com/llvm-project/libcxx-ci/builds/12164#01820d36-8444-4b5e-b2f5-a3a866703ed6
> lists the test as unsupported.
> 
> Our Docker doesn't install `clang-tools-$LLVM_LATEST_VERSION`.
> 
> Can you update our Docker file in a separate review and rebase this one after it passes.
> Maybe it's even better to split this patch in the missing `_LIBCPP_HIDE_FROM_ABI` and the test improvements. Then you can land the first part quickly without having the risk of merge conflicts in that part.
> 
Can you add a comment to explain the purpose of this file?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129968/new/

https://reviews.llvm.org/D129968