[libcxx-commits] [PATCH] D129968: [libc++] Add a bunch of missing _LIBCPP_HIDE_FROM_ABI

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

@Mordante @var-const @huixie90 @ldionne Please tell me which parts of this PR conflict with any of your PRs. I think it's mostly be the algorithms, especially `sort`.

Notable exceptions to adding `_LIBCPP_HIDE_FROM_ABI` are `__sort`, `__insertion_sort_incomplete` and `operator+(const _CharT*, const basic_string&)`. These have specializations in the dylib and I have them marked `_LIBCPP_HIDDEN` instead because of that.



================
Comment at: libcxx/include/__format/formatter_floating_point.h:106
 template <floating_point _Fp>
-static constexpr size_t __float_buffer_size(int __precision) {
   using _Traits = __traits<_Fp>;
----------------
@Mordante I'm guessing this was accidentally marked `static`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129968/new/

https://reviews.llvm.org/D129968