[libcxx-commits] [PATCH] D129964: [libc++][format] Improve format buffer.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__format/buffer.h:71
 
   _LIBCPP_HIDE_FROM_ABI auto make_output_iterator() {
     return back_insert_iterator{*this};
----------------
These existing functions should be `__uglified` I'll do that in a followup patch.


================
Comment at: libcxx/include/__format/buffer.h:103
+
+    __flush_on_overflow(__size);
+    if (__size <= __capacity_) {
----------------



================
Comment at: libcxx/include/__format/formatter_output.h:93
+template <__formatter::__char_type _CharT, __formatter::__char_type _OutCharT = _CharT>
+auto __copy(basic_string_view<_CharT> __str, output_iterator<const _OutCharT&> auto __out_it) -> decltype(__out_it) {
+  if constexpr (_VSTD::same_as<decltype(__out_it), _VSTD::back_insert_iterator<__format::__output_buffer<_OutCharT>>>) {
----------------
Forgot them here and the next functions too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129964/new/

https://reviews.llvm.org/D129964