[libcxx-commits] [PATCH] D129928: Conversion from '__int64' to 'long', possible loss of data

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for making the test compatible with MSVC STL. LGTM, one question.



================
Comment at: libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp:26
 template <typename Duration>
-constexpr long check_seconds(Duration d)
+constexpr long long check_seconds(Duration d)
 {
----------------
How do you feel about using `int64_t` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129928/new/

https://reviews.llvm.org/D129928