[libcxx-commits] [PATCH] D129668: [libc++] Improve updating data files.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added subscribers: mstorsjo, arichardson, mgorny.
Herald added a project: All.
Mordante added a subscriber: ldionne.
Mordante updated this revision to Diff 444369.
Mordante added a comment.
Mordante updated this revision to Diff 444377.
Mordante published this revision for review.
Mordante added a reviewer: ldionne.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Changed the properties without updating the tables.
This should result in a failing CI run.


Mordante added a comment.

https://buildkite.com/llvm-project/libcxx-ci/builds/12076#0181f8eb-7df5-4b77-8917-a78fd27e567f
fails as expected.


Mordante added a comment.

Finalize the patch for review.



================
Comment at: libcxx/utils/CMakeLists.txt:2
 
+find_program(LIBCXX_CLANG_FORMAT "clang-format" REQUIRED)
+
----------------
For developers and the CI a hard requirement is fine. But this might not be good for vendors.
We could make the target using formatting conditional on whether or not the binary is found.
That would however mean that if clang-format isn't found the CI will pass.

So I'm considering to make all these targets to depend on clang-format.
@ldionne Let's discuss what the best approach is.


This changes makes it easier to update the Unicode data files used for
the Extended Graphme Clustering as added in D126971 <https://reviews.llvm.org/D126971>.

Depends on D126971 <https://reviews.llvm.org/D126971>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129668

Files:
  libcxx/utils/CMakeLists.txt
  libcxx/utils/data/unicode/GraphemeBreakProperty.txt
  libcxx/utils/data/unicode/GraphemeBreakTest.txt
  libcxx/utils/data/unicode/README.txt
  libcxx/utils/data/unicode/emoji-data.txt
  libcxx/utils/generate_extended_grapheme_cluster_table.py
  libcxx/utils/generate_extended_grapheme_cluster_test.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129668.444377.patch
Type: text/x-patch
Size: 297300 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220715/a48bd048/attachment-0001.bin>