[libcxx-commits] [PATCH] D128928: [libc++] Treat incomplete features just like other experimental features

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general I'm happy, but I see a lot of bootstrap CI failures. Are they due to this patch or unrelated.



================
Comment at: libcxx/benchmarks/CMakeLists.txt:126
   endif()
-  if (TARGET cxx_experimental)
-    target_link_libraries(${libcxx_target} PRIVATE cxx_experimental)
-  endif()
-  target_link_libraries(${libcxx_target} PRIVATE -lbenchmark)
+  target_link_libraries(${libcxx_target} PRIVATE cxx_experimental -lbenchmark)
   if (LLVM_USE_SANITIZER)
----------------
Is this change really needed, should we instead set `-fexperimental-libray` unconditionally.

Drive-by why `-lbenchmark` instead of `benchmark`?


================
Comment at: libcxx/docs/Status/Cxx20.rst:37
 .. csv-table::
    :file: Cxx20Papers.csv
    :header-rows: 1
----------------
ldionne wrote:
> TODO: Add a release note explaining what `-funstable` does.
This is still open.


================
Comment at: libcxx/src/CMakeLists.txt:336
 cxx_add_common_build_flags(cxx_experimental)
+target_compile_options(cxx_experimental PUBLIC -D_LIBCPP_ENABLE_EXPERIMENTAL) # TODO: Replace this by a proper compiler option once supported
 
----------------
If possible I'd like to see this solved before landing since D121141 has been approved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128928/new/

https://reviews.llvm.org/D128928