[libcxx-commits] [libcxx] 64d63f4 - [libc++] Error if someone tries to use MSVC and tell them to contact the libc++ developers

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 14 10:35:16 PDT 2022


Author: Nikolas Klauser
Date: 2022-07-14T19:35:12+02:00
New Revision: 64d63f4823afeeaa2f8abc256bfe14b89f4daeae

URL: https://github.com/llvm/llvm-project/commit/64d63f4823afeeaa2f8abc256bfe14b89f4daeae
DIFF: https://github.com/llvm/llvm-project/commit/64d63f4823afeeaa2f8abc256bfe14b89f4daeae.diff

LOG: [libc++] Error if someone tries to use MSVC and tell them to contact the libc++ developers

Nobody knows if there are users of libc++ with MSVC. Let's try to find that out and encourage them to upstream their changes to make that configuration work.

Reviewed By: ldionne, #libc

Spies: libcxx-commits

Differential Revision: https://reviews.llvm.org/D129055

Added: 
    

Modified: 
    libcxx/include/__config

Removed: 
    


################################################################################
diff  --git a/libcxx/include/__config b/libcxx/include/__config
index f0e36a65cf13..25e2763088d5 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -214,6 +214,12 @@
 #    error "libc++ only supports C++03 with Clang-based compilers. Please enable C++11"
 #  endif
 
+#  ifdef _LIBCPP_COMPILER_MSVC
+#    error If you successfully use libc++ with MSVC please tell the libc++ developers and consider upstreaming your \
+changes. We are not aware of anybody using this configuration and know that at least some code is currently broken. \
+If there are users of this configuration we are happy to provide support.
+#  endif
+
 // FIXME: ABI detection should be done via compiler builtin macros. This
 // is just a placeholder until Clang implements such macros. For now assume
 // that Windows compilers pretending to be MSVC++ target the Microsoft ABI,


        


More information about the libcxx-commits mailing list