[libcxx-commits] [PATCH] D129741: [libc++][ranges][NFC] Consolidate range algorithm checks for returning `dangling`.
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jul 14 07:12:54 PDT 2022
philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.
I think we should run the `dangling` tests and check their outputs. In theory we could optimize on an algorithms returning `ranges::dangling`. For some algorithms this would work perfectly, but for others there are side-effects where the current tests would catch the problem while this test doesn't. The `nonbool` and `invoke` changes LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129741/new/
https://reviews.llvm.org/D129741
More information about the libcxx-commits
mailing list