[libcxx-commits] [PATCH] D127672: [libc++] Test the size of basic_string

Thu Jul 14 05:04:58 PDT 2022

philnik added a comment.

In D127672#3650694 <https://reviews.llvm.org/D127672#3650694>, @hubert.reinterpretcast wrote:

> In D127672#3650566 <https://reviews.llvm.org/D127672#3650566>, @hubert.reinterpretcast wrote:
>
>> As far as I can tell, the values //are// correct. I will need to see if the failures show up when using the LIT harness.
>
> These pass for me with the LIT harness. Perhaps the precommit CI does make use of the "Parents" metadata?
> The metadata shows that your patch is a commit on top of rGaf41955a49725c8ddc69d94b1874bbbbd608729e <https://reviews.llvm.org/rGaf41955a49725c8ddc69d94b1874bbbbd608729e>.
> Xing's fix in rG60f7bdfd0317cb38eda54637cdab9baed8ae2f57 <https://reviews.llvm.org/rG60f7bdfd0317cb38eda54637cdab9baed8ae2f57> occurs after that.
>
> My guess is that the CI will pass if you rebase.

Thanks! I thought I had already rebased, but apparently not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127672/new/

https://reviews.llvm.org/D127672