[libcxx-commits] [PATCH] D129549: [libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 13 12:37:32 PDT 2022


var-const added inline comments.


================
Comment at: libcxx/include/module.modulemap.in:321
       module ranges_equal                    { private header "__algorithm/ranges_equal.h" }
+      module ranges_equal_range              { private header "__algorithm/ranges_equal_range.h" }
       module ranges_fill                     { private header "__algorithm/ranges_fill.h" }
----------------
Mordante wrote:
> In about two week we'll branch the LLVM 15 release. Should we remove the not implemented changes in the branch after branching?
> I mainly wonder about the changes to this file and CMakeLists.txt. Without these the files with the broken placeholder algorithms aren't visible for users.
The placeholder headers aren't included in `<algorithm>`, so they shouldn't be visible through normal C++ means -- or do you mean they would be somehow visible in the build system?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129549/new/

https://reviews.llvm.org/D129549



More information about the libcxx-commits mailing list