[libcxx-commits] [PATCH] D128744: [libc++][ranges] Implement `ranges::partial_sort`.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 12 18:39:15 PDT 2022


var-const marked 2 inline comments as done.
var-const added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.sort/partial.sort/ranges_partial_sort.pass.cpp:281
+  }
+
+  return true;
----------------
huixie90 wrote:
> btw,  you can rebase and try sorting the `ProxyRange` to verify if `iter_swap` is used properly used and sorting `ProxyRange` of  move only types to see if `iter_move` is properly used
I'd prefer to do this in a follow-up once this lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128744/new/

https://reviews.llvm.org/D128744



More information about the libcxx-commits mailing list