[libcxx-commits] [PATCH] D129520: [libc++][ranges] implement `std::ranges::set_symmetric_difference`

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 12 11:39:12 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/include/__algorithm/set_symmetric_difference.h:39
+template <class _Compare, class _InIter1, class _Sent1, class _InIter2, class _Sent2, class _OutIter>
+_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 __set_symmetric_difference_result< _InIter1, _InIter2, _OutIter>
+__set_symmetric_difference(
----------------
var-const wrote:
> Nit: this space looks weird -- is this done by `clang-format`?
clang-format keeps the spacing as-is because of `SpacesInAngles: Leave`. I think it could be improved to remove whitespaces anwhere where there aren't two consecutive brackets, but you can just remove the whitespace and clang-format will be happy. This is so clang-format doesn't break C++03 code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129520/new/

https://reviews.llvm.org/D129520



More information about the libcxx-commits mailing list