[libcxx-commits] [PATCH] D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX

[David Tenty via Phabricator via libcxx-commits]

daltenty added inline comments.


================
Comment at: libcxx/include/__config:319
 
+#if defined(_AIX)
+#    define _LIBCPP_BASIC_IOS_HAS_FILL_SET 1
----------------
daltenty wrote:
> What about adding an ABI guard around this whole block? Something like:
> ```
> #if _LIBCPP_ABI_BASIC_IOS_HAS_FILL_SET_IF_NEEDED
> ```
> And defining that for the unstable ABI (_LIBCPP_ABI_VERSION >= 2) in the relevant block here? That would let folks not requiring the stable ABI  on the below platforms pickup the fix automatically if needed.
edit: or rather the reverse check:
```
#ifndef _LIBCPP_ABI_BASIC_IOS_HAS_FILL_SET_IF_NEEDED
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124555/new/

https://reviews.llvm.org/D124555