[libcxx-commits] [PATCH] D129441: [libc++] Update clang-format style.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 12 10:06:18 PDT 2022


ldionne added a comment.

+1 on `PenaltyIndentedWhitespace`.

Regarding indenting inner namespaces, my opinion (which has been expressed by @philnik) is that indenting small less-than-one-screen namespaces is useful, but longer ones not so much. Would it be possible to handle that in `clang-format`? Maybe the option could be something like `NamespaceIndentationThreshold: 50` (namespaces 50 lines or less are indented, others are not).

Also, it would be useful to format one file as part of this review just to show how this changes -- it can be omitted upon committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129441/new/

https://reviews.llvm.org/D129441



More information about the libcxx-commits mailing list