[libcxx-commits] [PATCH] D128744: [libc++][ranges] Implement `ranges::partial_sort`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const marked 4 inline comments as done.
var-const added inline comments.


================
Comment at: libcxx/include/__algorithm/lower_bound.h:30
 
-template <class _IterOps, class _Iter, class _Sent, class _Type, class _Proj, class _Comp>
+template <class _Tag, class _Iter, class _Sent, class _Type, class _Proj, class _Comp>
 _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17
----------------
huixie90 wrote:
> var-const wrote:
> > philnik wrote:
> > > The name `_Tag` looks quite opaque to me. How about `_Namespace` or something like that?
> > How about something like `_AlgFamily` or `_InvocationContext`?
> Or `_Policy` and we have `_RangesPolicy` and `_ClassicPolicy`
I really like "policy" -- went with `_RangeAlgPolicy` and `_ClassicAlgPolicy` (in https://reviews.llvm.org/D129390). Please let me know what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128744/new/

https://reviews.llvm.org/D128744