[libcxx-commits] [PATCH] D129312: [SystemZ][z/OS] Add custom config file for libc++/abi testing

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi requested changes to this revision.
zibi added a comment.
This revision now requires changes to proceed.

Looking good, I wonder if we can incorporating a small change to set PATH, see inline comment in `ibm-zos-libc++-shared.cfg.in`.



================
Comment at: libcxx/CMakeLists.txt:279
 
+if (ZOS)
+  set(LIBCXX_DATASET_PREFIX "" CACHE STRING "Use the dataset prefix.")
----------------
Consider moving this to `Configure System` section were various output directories are being set, for example: LIBCXX_LIBRARY_DIR.


================
Comment at: libcxx/test/configs/ibm-zos-libc++-shared.cfg.in:33-34
+
+config.substitutions.append(('%{exec}',
+    '%{{executor}} --execdir %T --env _BPXK_AUTOCVT=ON STEPLIB={0} -- '.format(steplib)))
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129312/new/

https://reviews.llvm.org/D129312