[libcxx-commits] [PATCH] D129414: [libc++][ranges][NFC] Consolidate some repetitive range algorithm tests:

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.compile.pass.cpp:201
+  // `reverse` has neither a projection nor a predicate.
+  // `rotate` has neither a projection nor a predicate.
+  // `shuffle` has neither a projection nor a predicate.
----------------
var-const wrote:
> philnik wrote:
> > I would just omit the algorithms for which the test doesn't apply, like we do in the other `robust_against_x` tests.
> Hmm, I'm inclined to leave these in. It makes it easier to verify that no algorithm has been accidentally omitted.
Do it as you see fit. I don't have any strong opinions here. I mostly wanted to note that this deviates from the other tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129414/new/

https://reviews.llvm.org/D129414