[libcxx-commits] [PATCH] D129414: [libc++][ranges][NFC] Consolidate some repetitive range algorithm tests:

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 11 13:45:00 PDT 2022


var-const marked 3 inline comments as done.
var-const added inline comments.


================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.compile.pass.cpp:201
+  // `reverse` has neither a projection nor a predicate.
+  // `rotate` has neither a projection nor a predicate.
+  // `shuffle` has neither a projection nor a predicate.
----------------
philnik wrote:
> I would just omit the algorithms for which the test doesn't apply, like we do in the other `robust_against_x` tests.
Hmm, I'm inclined to leave these in. It makes it easier to verify that no algorithm has been accidentally omitted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129414/new/

https://reviews.llvm.org/D129414



More information about the libcxx-commits mailing list