[libcxx-commits] [PATCH] D129414: [libc++][ranges][NFC] Consolidate range algorithm tests with non-boolean predicates.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nits.



================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_nonbool_predicates.compile.pass.cpp:174-178
+int main(int, char**) {
+  test_all();
+
+  return 0;
+}
----------------
The main shouldn't be required anymore. Also applies to the invoke test.


================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Please update the PR title.


================
Comment at: libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.compile.pass.cpp:201
+  // `reverse` has neither a projection nor a predicate.
+  // `rotate` has neither a projection nor a predicate.
+  // `shuffle` has neither a projection nor a predicate.
----------------
I would just omit the algorithms for which the test doesn't apply, like we do in the other `robust_against_x` tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129414/new/

https://reviews.llvm.org/D129414