[libcxx-commits] [PATCH] D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659)

Mon Jul 11 13:06:57 PDT 2022

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM modulo one nit. I leave the final approval for @ldionne to land this before the issue is voted in.

================
Comment at: libcxx/docs/Status/Cxx20.rst:50
+   .. [#note-P0883.1] P0883: shared_ptr and floating-point changes weren't applied as they themselves aren't implemented yet.
+   .. [#note-P0883.2] P0883: ``ATOMIC_FLAG_INIT`` was marked deprecated in 14.0, but was undeprecated with the implementation of LWG3659 in 15.0.
    .. [#note-P2231] P2231: Optional is complete. The changes to variant haven't been implemented yet.
----------------

================
Comment at: libcxx/docs/Status/Cxx2bIssues.csv:159
 "`3657 <https://wg21.link/LWG3657>`__","``std::hash<std::filesystem::path>`` is not enabled","February 2022","",""
+"`3659 <https://wg21.link/LWG3659>`__","Consider ``ATOMIC_FLAG_INIT`` undeprecation","July 2022","|Complete|","15.0"
 "`3660 <https://wg21.link/LWG3660>`__","``iterator_traits<common_iterator>::pointer`` should conform to §[iterator.traits]","February 2022","|Complete|","14.0"
----------------
tambre wrote:
> Mordante wrote:
> > I would like to see an update the note for `P0883` with information regarding this LWG issue.
> Done. Added the note to the P0883's line on the C++20 status page. Hopefully that's what you intended.
Yes that's what I intended.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129380/new/

https://reviews.llvm.org/D129380