[libcxx-commits] [PATCH] D129503: [libc++] Rename variables to use the snake case instead of camel case

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 11 11:38:31 PDT 2022


Mordante accepted this revision.
Mordante added a comment.

LGTM.



================
Comment at: libcxx/include/__algorithm/set_intersection.h:29
   _InIter2 in2;
   _OutIter out;
 
----------------
These names look suspicious, the struct has underscores, the members not. Since this patch fixes a CI breakage I prefer to land this patch as is and improve this in a separate patch.

For your information `__out` is a name you can't use. It's used by Microsoft and will fail in the CI in our nasty-macro test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129503/new/

https://reviews.llvm.org/D129503



More information about the libcxx-commits mailing list