[libcxx-commits] [PATCH] D120186: [pstl] Implementation of Grand Central Dispatch backend

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: pstl/include/pstl/internal/gcd/parallel_stable_partial_sort.h:29
+    // TODO: The partial sort implementation should be shared with the other backends.
+    __leaf_sort(__xs, __xe, __comp);
+}
----------------
nadiasvertex wrote:
> philnik wrote:
> > This isn't ADL-proof.
> Okay. What do you suggest?
Oh sorry, never mind. I didn't see that the function was an argument.


================
Comment at: pstl/include/pstl/internal/gcd/util.h:104
+        // is safe to pass a pointer to the stack allocated data above.
+        dispatch_apply_f(__n_chunks_, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), this,
+                         [](void* __ctx, std::size_t __chunk)
----------------
nadiasvertex wrote:
> philnik wrote:
> > Also not ADL-proof
> It's a C-function. What do you suggest?
Just put `::` in front of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120186/new/

https://reviews.llvm.org/D120186