[libcxx-commits] [PATCH] D129056: [libc++] Prefer __has_builtin for detecting compiler-provided type_traits

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jul 10 05:10:45 PDT 2022


Mordante added inline comments.


================
Comment at: libcxx/include/__type_traits/is_convertible.h:32
 
-#else  // __has_feature(is_convertible_to)
+#else  // __has_builtin(__is_convertible_to)
 
----------------
Mordante wrote:
> please update the comment to match the `#if`, same for the `#endif`.
I've addressed this comment myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129056/new/

https://reviews.llvm.org/D129056



More information about the libcxx-commits mailing list