[libcxx-commits] [PATCH] D129399: [libcxx] [test] Merge the experimental-lib-exports testcases into static-lib-exports

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: ldionne.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Since bb939931a1adb9a47a2de13c359d6a72aeb277c8 <https://reviews.llvm.org/rGbb939931a1adb9a47a2de13c359d6a72aeb277c8>, the c++experimental
library is always built, so these tested files should always be built
(even if they aren't used in tests).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129399

Files:
  libcxx/test/libcxx/vendor/clang-cl/experimental-lib-exports.sh.cpp
  libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp
  libcxx/test/libcxx/vendor/mingw/experimental-lib-exports.sh.cpp
  libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp


Index: libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp
===================================================================
--- libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp
+++ libcxx/test/libcxx/vendor/mingw/static-lib-exports.sh.cpp
@@ -12,3 +12,5 @@
 // directives in MinGW builds.
 
 // RUN: llvm-readobj --coff-directives "%{lib}/libc++.a" | not grep -i "export:" > /dev/null
+
+// RUN: llvm-readobj --coff-directives "%{lib}/libc++experimental.a" | not grep -i "export:" > /dev/null
Index: libcxx/test/libcxx/vendor/mingw/experimental-lib-exports.sh.cpp
===================================================================
--- libcxx/test/libcxx/vendor/mingw/experimental-lib-exports.sh.cpp
+++ /dev/null
@@ -1,14 +0,0 @@
-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// REQUIRES: target={{.+}}-windows-gnu && c++experimental
-
-// This file checks that the built experimental static library doesn't contain dllexport
-// directives in MinGW builds.
-
-// RUN: llvm-readobj --coff-directives "%{lib}/libc++experimental.a" | not grep -i "export:" > /dev/null
Index: libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp
===================================================================
--- libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp
+++ libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp
@@ -12,3 +12,5 @@
 // directives in clang-cl builds.
 
 // RUN: llvm-readobj --coff-directives "%{lib}/libc++.lib" | not grep -i "export:" > /dev/null
+
+// RUN: llvm-readobj --coff-directives "%{lib}/libc++experimental.lib" | not grep -i "export:" > /dev/null
Index: libcxx/test/libcxx/vendor/clang-cl/experimental-lib-exports.sh.cpp
===================================================================
--- libcxx/test/libcxx/vendor/clang-cl/experimental-lib-exports.sh.cpp
+++ /dev/null
@@ -1,14 +0,0 @@
-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-// REQUIRES: msvc && c++experimental
-
-// This file checks that the built experimental static library doesn't contain dllexport
-// directives in clang-cl builds.
-
-// RUN: llvm-readobj --coff-directives "%{lib}/libc++experimental.lib" | not grep -i "export:" > /dev/null


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129399.443354.patch
Type: text/x-patch
Size: 2842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220708/4433aba9/attachment.bin>