[libcxx-commits] [PATCH] D129054: [libc++] Consolidate the different [[nodiscard]] configuration options into a single one

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D129054#3631115 <https://reviews.llvm.org/D129054#3631115>, @philnik wrote:

> In D129054#3630743 <https://reviews.llvm.org/D129054#3630743>, @Mordante wrote:
>
>> I wonder whether we want to take this approach. We've had patches in the past to remove this feature and make all `[[nodiscard]]` extensions always enabled. MSVC STL already does this and there have been done some tests on Google and Apple codebases. (I don't recall whether the results have been posted.)
>>
>> How about going in that direction instead? probably we should then do this shortly after LLVM 15 is branched.
>
> That's what I want to do in D128267 <https://reviews.llvm.org/D128267>, but there @ldionne requested that the different configuration macros should be consolidated into one, which I'm doing in this patch. I think these are two separate issues, so I wanted to land them separately.

I missed that patch, thanks for the information. In that case consider my comment above as resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129054/new/

https://reviews.llvm.org/D129054