[libcxx-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

[Jonas Devlieghere via Phabricator via libcxx-commits]

JDevlieghere added a comment.

Hey Louis,

This change breaks two LLDB tests: `TestQueueFromStdModule.py` and `TestStackFromStdModule.py`. I'm not at all familiar with these tests, but it seems the error mode is that the debugger can't find certain symbols:

  error: Couldn't lookup symbols:
    __ZNSt3__1miERKNS_13move_iteratorIPP1CEES6_

Given that the bot has been red for 20 hours I went ahead and reverted your change in 61d417ceff90c4bd99bfed082d81bcc33ecf5a45 <https://reviews.llvm.org/rG61d417ceff90c4bd99bfed082d81bcc33ecf5a45>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127444/new/

https://reviews.llvm.org/D127444