[libcxx-commits] [PATCH] D129047: [libc++] Improves pragma system_header test.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 6 11:54:59 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8cb5c82ad23b: [libc++] Improves pragma system_header test. (authored by Mordante).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129047/new/

https://reviews.llvm.org/D129047

Files:
  libcxx/test/libcxx/lint/lint_headers.sh.py


Index: libcxx/test/libcxx/lint/lint_headers.sh.py
===================================================================
--- libcxx/test/libcxx/lint/lint_headers.sh.py
+++ libcxx/test/libcxx/lint/lint_headers.sh.py
@@ -20,9 +20,11 @@
 
 def check_for_pragma_GCC_system_header(pretty_fname, lines):
     if pretty_fname not in ['__undef_macros']:
-        if '#  pragma GCC system_header\n' not in lines:
-            print('FAILED TO FIND #  pragma GCC system_header in libcxx/include/%s!' % pretty_fname)
-            return False
+        for line in lines:
+            if re.match('# *pragma GCC system_header\n', line):
+                return True
+        print('FAILED TO FIND #  pragma GCC system_header in libcxx/include/%s' % pretty_fname)
+        return False
     return True
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129047.442655.patch
Type: text/x-patch
Size: 791 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220706/d1150dad/attachment.bin>


More information about the libcxx-commits mailing list